Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: skip bunding Mermaid ZenUML #766

Merged

Conversation

aloisklink
Copy link
Member

📑 Summary

Instead of bundling the @mermaid-js/mermaid-zenuml package ourselves, we can let the user install their own version of it.

📏 Design Decisions

This lowers the size of the dist/index.html file by about 1.3 MB:

Before

$ npx vite build
vite v4.5.5 building for production...
✓ 656 modules transformed.
dist/index.html  5,627.39 kB │ gzip: 2,451.54 kB
✓ built in 9.67s

After

$ npx vite build
vite v4.5.5 building for production...
✓ 638 modules transformed.
dist/index.html  4,340.56 kB │ gzip: 2,124.28 kB
✓ built in 6.63s

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted master branch

Instead of bundling the `@mermaid-js/mermaid-zenuml` package ourselves,
we can let the user install their own version of it.
@MindaugasLaganeckas MindaugasLaganeckas merged commit e0ef9f7 into mermaid-js:master Nov 12, 2024
5 of 6 checks passed
@aloisklink aloisklink deleted the perf/skip-bundling-zenuml branch November 12, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants